feat: show last message for ghost group (WPB-25285) - #5127
Open
sbakhtiarov wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-25285
https://wearezeta.atlassian.net/browse/WPB-25285
What's new in this PR?
Issues
For "ghost" groups (groups pending automatic deletion because they have no eligible admins), the conversation list should surface the pending-deletion state as the last message, and it must not be hidden behind unread-event
summaries.
Causes
The Kalium side now emits a dedicated
MessagePreviewContent.AdminlessDeleteReminderpreview, but the Android preview mapper had no branch for it and would otherwise fall through the unread-event aggregation logic.Solutions
MessagePreviewContentMapper:MessagePreviewContent.AdminlessDeleteReminderto aTextMessageusing the newlast_message_adminless_delete_reminderstring.toUIPreviewfor the reminder so it always shows thepending-deletion text regardless of unread-event counts.
last_message_adminless_delete_reminder→ "Will be deleted soon".Dependencies
Needs releases with: